Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland role merge #165330

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Reland role merge #165330

merged 3 commits into from
Mar 18, 2025
+334 −46

Conversation

chunhtai
Copy link
Contributor

the previous pr causes some issue with mobile platform.
The change is in second commit

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) and removed f: material design flutter/packages/flutter/material repository. labels Mar 17, 2025
@chunhtai chunhtai force-pushed the reland-role-merge branch from 1801f53 to 77276dd Compare March 17, 2025 18:27
@github-actions github-actions bot added the f: material design flutter/packages/flutter/material repository. label Mar 17, 2025
@chunhtai chunhtai force-pushed the reland-role-merge branch from f39fdee to 7cb9eb3 Compare March 17, 2025 21:39
@chunhtai chunhtai requested a review from yjbanov March 17, 2025 21:39
yjbanov
yjbanov approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chunhtai
Copy link
Contributor Author

g3fix cl/737785383

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 18, 2025
Merged via the queue into flutter:master with commit ce667ed Mar 18, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chunhtai @yjbanov