Prevent explicit roles from merging #164732
Merged
+264
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Mar 6, 2025
| _hasFlag(SemanticsFlag.isLink) || | ||
| _hasFlag(SemanticsFlag.scopesRoute) || | ||
| _hasFlag(SemanticsFlag.isImage) || | ||
| _hasFlag(SemanticsFlag.isKeyboardKey)) { |
There was a problem hiding this comment.
Should we also have isButton here?
There was a problem hiding this comment.
no, an image can also be a button. same for keyboard key. button is more of a trait now...
now I think of it, there is also a searchBox/combobox which can be compatible with istextfield... it almost feels like the compatibility is per flag and role based..
There was a problem hiding this comment.
we may need to make the role and enhance enum to be able to enter compatible flags
There was a problem hiding this comment.
discussed offline, for role that may be compatibile, we could (a) factor out some aspect of it to a semanticsproperty(e.g searchable) (b) comes up with a way to customize merging for each enum (e.g. an enhance enum that include other mergable roles).
we can deal with them case by case when these kind of problem raise up. For now, we will go ahead with this pr
|
autosubmit label was removed for flutter/flutter/164732, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/164732, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
611eafa to
5bdf68a
Compare
|
autosubmit label was removed for flutter/flutter/164732, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/164732, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Mar 14, 2025
This reverts commit c2bb3ac.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 15, 2025
This reverts commit c2bb3ac. <!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> the previous pr may break some of the mobile a11y. some newly splitted role can't be focus by mobile a11y focus, will need to fix some of the engine code first ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 17, 2025
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Mar 17, 2025
This reverts commit 3d74fe1.
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Mar 17, 2025
This reverts commit 3d74fe1.
chunhtai
added a commit
to chunhtai/flutter
that referenced
this pull request
Mar 17, 2025
This reverts commit 3d74fe1.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merging explicit roles, some of the information may be dropped.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.