Page MenuHomePhabricator

GlobalBlockingHooks::onSpecialPasswordResetOnSubmit is never called
Closed, ResolvedPublic

Description

The GlobalBlockingHooks::onSpecialPasswordResetOnSubmit method is never called. This is because the code that calls this hook will first check for any active blocks, which will include global blocks. As all global blocks prevent password resets, the hook handler method will never be called as the code will never allow the user to submit a password request (or get to the point of calling the hook in the case of the API).

As such the GlobalBlockingHooks::onSpecialPasswordResetOnSubmit method is unnecessary and should be removed.

Event Timeline

Change #1040217 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Remove unnecessary ::onSpecialPasswordResetOnSubmit handler

https://gerrit.wikimedia.org/r/1040217

Change #1040217 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Remove unnecessary ::onSpecialPasswordResetOnSubmit handler

https://gerrit.wikimedia.org/r/1040217