Change 1008518 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Move action link generation to GlobalBlockingLinkBuilder

https://gerrit.wikimedia.org/r/1008518

Change 1013025 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Add action links to global blocking logging entries.

https://gerrit.wikimedia.org/r/1013025

Change #1008518 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Move action link generation to GlobalBlockingLinkBuilder

https://gerrit.wikimedia.org/r/1008518

Change #1013025 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Add action links to global blocking logging entries

https://gerrit.wikimedia.org/r/1013025

Suggested QA steps (either for patchdemo or local wiki, as beta wikis do not have this change due to T360595):

1. Log into an account with the steward, sysop, and suppressor groups
2. If you do not have any global blocking log entries in your log, create a few by performing a few global blocks, removing global blocks, and changing the local status of global blocks
3. Go to Special:Log and filter for logs in the Global block log category
4. Verify that all the logs have action links next to them. For example, they should look like the following:

5. Globally block an account
6. Locally block the account you blocked in step 5 with the hideuser (Hide username from edits and lists) setting enabled
7. Find a global block entry for a target you didn't block with hideuser in step 5 (such as an IP target or another username). Revision delete the log parameters and target for that log entry.
   1. "Revision deleting" a log entry can be done by clicking the checkbox next to the log entry and then clicking the Change visibility of selected log entries button at the top of the log page). This takes you to Special:RevisionDelete which can then be used to hide the target and parameters. Make sure to also select Suppress data from administrators as well as others too.
8. Log into an account with just the sysop group
9. Verify that the log for global block performed in step 5 has no action links and you cannot see the target username of the block
10. Verify that the log entry which you revision deleted in step 7 does not have any action links.
11. Verify that for other logs where you can see the target of the block, you see the action links with one single link where the link text is local status.
12. While logged-out, load Special:Log and verify that no action links are shown

@dom_walden raised the issue that if the Hide target and parameters checkbox is checked that the action links are still provided. This was mentioned in the QA of T358865.

As such, I'm moving this back to in progress and will work on a fix for that.

Change #1014503 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Hide action links if action is deleted for gblblock log entries

https://gerrit.wikimedia.org/r/1014503

(See T359584#9657841 for suggested QA steps)

Change #1014503 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Hide action links if action is deleted for gblblock log entries

https://gerrit.wikimedia.org/r/1014503

I can confirm T359584#9657841.

Test environment: local docker GlobalBlocking – (95ca8f1) 07:28, 22 April 2024.