Page MenuHomePhabricator

Update the Thanks extension to be compatible with the IP Masking project
Closed, ResolvedPublic

Description

Project documentation: IP Editing: Privacy Enhancement and Abuse Mitigation

User story & summary:
  • Temporary account holders should be able to receive Thanks.
  • Temporary account holders should not be able to send Thanks.
Background & research:

This decision was made for the following reasons:

  • ensuring Thanks isn't an abuse vector
  • ensuring (where it makes sense) Temp account UX is similar to the current IP editor UX
  • ensuring we aren't picking an unnecessarily complex technical solution (By default temp accounts can receive Thanks. Since this feature has been shown to help with short-term retention, I don't think there is reason to devote time to disabling the ability to Thank a temp account).
Testing:
  • Test from a regular account: sending Thanks to a temp account
  • Test from a Temp account: receiving Thanks from a regular account.
  • Test from a Temp account: should not see the option to send Thanks.
  • Test Special:Log to view the Thanks log to ensure the temp account name is displayed correctly.
Acceptance Criteria:

Given I'm logged out or logged into a Temp account,
When I view a page that displays Thanks,
Then I don't see the option to send Thanks.

Given I'm logged into a regular / named account,
When I view a page that displays Thanks,
Then I can send Thanks to a temp account.

Event Timeline

KStoller-WMF renamed this task from Thanks extension + IP Masking to Update the Thanks extension to be compatible with the IP Masking project.Sep 6 2023, 12:18 AM

Change 957354 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/Thanks@master] IP Masking: Do not allow temporary users to thank other users

https://gerrit.wikimedia.org/r/957354

Change 957354 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] IP Masking: Do not allow temporary users to thank other users

https://gerrit.wikimedia.org/r/957354

Etonkovidova subscribed.

Added to T341839: [QA task] IP masking - temp users testing in production.
Also, api call was checked: Speciální:API_pískoviště#action=thank&format=json&rev=4435 which gives a correct output:

"error": {
       "code": "notloggedin",
       "info": "Anonymous users cannot send thanks"