Page MenuHomePhabricator
Create Task
Maniphest T281536

Schema:EditAttemptStep uses non-inclusive language.
Open, Needs TriagePublic
Actions

Description

While working on T277951, I was unable to correct code, used by https://meta.wikimedia.org/wiki/Schema:EditAttemptStep that relates to implementation details of the SpamBlacklist and TitleBlacklist extensions.

I've left a FIXME for now, but this is blocked on working out the future of those two extensions.

It might make sense for this instrumentation to be adapted separately, I defer to editing team about whether that makes sense.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT254646 Reconsidering how we name things
 OpenNoneT281536 Schema:EditAttemptStep uses non-inclusive language.
 OpenNoneT279275 Move all the functionality of {Spam,Title}Blacklist extensions into AbuseFilter and retire them
 ResolvedDaimonaT191740 Bundle AbuseFilter extension with MediaWiki
 ResolvedDaimonaT192325 Setup phan for AbuseFilter
Restricted Task
 ResolvedDaimonaT223654 AbuseFilterCheckMatch API reveals suppressed edits and usernames (CVE-2021-31547)
 ResolvedDaimonaT213006 Create a script to update afl_var_dump, drop back-compat code
 ResolvedUrbanecmT246539 Dry-run, then actually run updateVarDumps
 DeclinedDaimonaT246938 How to update/delete ExternalStore entries?
 ResolvedDaimonaT252696 Find a good way to run the updateVarDumps script on large wikis
 ResolvedDaimonaT152394 AbuseFilter privacy concerns on action == 'createaccount' and 'accountname' (CVE-2021-31552)
 ResolvedDaimonaT71367 page_recent_contributors leaks revdeleted user names (CVE-2021-31545)
 ResolvedDaimonaT199544 Make AbuseFilter work on PostgreSQL and SQLite (epic)
 Resolvedmatej_suchanekT62639 Database: SQLite and PG are missing columns
 ResolvedDaimonaT42757 Joins on INTEGER and TEXT fail with PostgreSQL
 ResolvedDaimonaT193068 Add support for SQLite and postgre when searching patterns
 Resolvedmatej_suchanekT199506 Investigate possible issues with PostgreSQL
 Resolvedmatej_suchanekT199507 Investigate possible issues with SQLite
 ResolvedPRODUCTION ERRORDaimonaT221357 Read timeout reached while viewing AbuseLog
 ResolvedDaimonaT251967 quibble-vendor-sqlite-php72-docker is broken by AbuseFilter
 ResolvedUmherirrenderT259377 Migrate AbuseFilter to Abstract Schema
 ResolvedDaimonaT220791 afl_filter should be split in afl_filter_id and afl_global
 ResolvedMarosteguiT234052 Add abuse_filter_log.afl_filter_id and afl_global columns
 Resolved• BstormT234615 Wikireplicas changes for abuse_filter_log including two new columns
 ResolvedDaimonaT269712 Migrate afl_filter to afl_filter_id and afl_global
 ResolvedUrbanecmT269713 Run the MigrateAflFilter script for AbuseFilter
 ResolvedMarosteguiT291719 Remove abuse_filter_log.afl_filter column and adjust schema consequently from Wikimedia production
 ResolvedrookT291806 Remove afl_filter column from the views
 OpenFeatureNoneT47747 Create a tool like SpamBlacklist in AbuseFilter
 OpenLadsgroupT337431 Rework MediaWiki:SpamBlacklist
 OpenNoneT279476 Move title blacklist rules to a database table
 OpenNoneT279477 Move spam blacklist rules to a database table
 OpenNoneT254650 Rename TitleBlacklist
 OpenNoneT254649 Rename SpamBlacklist
 OpenNoneT190521 Change name of spam-blacklist/spam-whitelist to link-blacklist/link-whitelist

Event Timeline

Jdlrobson created this task.Apr 29 2021, 9:49 PM
Jdlrobson added a subtask: T279275: Move all the functionality of {Spam,Title}Blacklist extensions into AbuseFilter and retire them.
Jdlrobson added a subtask: T254650: Rename TitleBlacklist.
Jdlrobson added a subtask: T254649: Rename SpamBlacklist.
jcrespo unsubscribed.Apr 30 2021, 5:42 AM
• matmarex subscribed.Apr 30 2021, 3:20 PM

We can't replace the references to SpamBlacklist and TitleBlacklist while they're still called that? There are separate tasks somewhere about renaming them. It's not clear to me what this task could accomplish without doing that first.

CDanis unsubscribed.Apr 30 2021, 3:23 PM
Jdlrobson added a comment.Apr 30 2021, 3:49 PM

Yep. This is stalled on (https://phabricator.wikimedia.org/T254650 and https://phabricator.wikimedia.org/T254649 unless it makes sense to remove/update instrumentation.

• Kormat unsubscribed.May 3 2021, 9:53 AM
Jdlrobson moved this task from Backlog to Team:Editing on the MobileFrontend board.May 4 2021, 9:14 PM
Jdlrobson moved this task from Team:Editing to MobileFrontend (Editor) on the MobileFrontend board.Nov 30 2021, 6:00 PM
Jdlrobson edited projects, added MobileFrontend (MobileFrontend (Editor)); removed MobileFrontend.
Enterprisey unsubscribed.Dec 7 2021, 2:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits