See parent task:
The only use is in the removeOldManualUserPages maintenance script, and is accompanied by a comment explaining that it is used to set $wgUser "For hooks not using RequestContext (e.g. AbuseFilter)".
What hooks remain that still need this?
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove use of global $wgUser | mediawiki/extensions/GlobalCssJs | master | +0 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Open | None | T159283 Deprecate non-configuration globals | |||
| Open | DannyS712 | T159299 Deprecate and remove $wgUser | |||
| Resolved | DannyS712 | T267861 [GOAL] Emit deprecation warnings reading from $wgUser | |||
| Resolved | DannyS712 | T245959 WMF deployed extensions need uses of global $wgUser removed [tracking] | |||
| Resolved | DannyS712 | T241618 GlobalCssJs needs uses of global $wgUser removed |
No. Most usages of $wgUser were removed with r460335.
Nowadays, AF only needs $wgUser to compute old_wikitext and new_wikitext for a RecentChanges row [1], which is unrelated to what that script is doing. However, that doesn't exclude other hook handlers (in other extensions) needing $wgUser. In general, all code that *writes* to $wgUser should be removed last.
[1] - Which in turn is blocked on a huge amount of tech debt, outlined at T213006.
Change 569396 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalCssJs@master] Remove use of global $wgUser
Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.
Hasn't been done yet because it writes to $wgUser, will do in 1.39 as part of the removal of $wgUser from everywhere
Change 569396 abandoned by Jforrester:
[mediawiki/extensions/GlobalCssJs@master] Remove use of global $wgUser
Reason:
This script was dropped in I1f6e8dda556f14828112fefaa1e8261df349f150.