| • Cntlsn | |
| Aug 12 2019, 4:21 PM |
| F30077774: Screen Shot 2019-08-23 at 11.10.01 AM.png | |
| Aug 23 2019, 6:11 PM |
| F30048286: Screen Shot 2019-08-19 at 2.54.57 PM.png | |
| Aug 19 2019, 9:56 PM |
| F30009086: Screenshot 2019-08-12 18.20.23.png | |
| Aug 12 2019, 4:21 PM |
| F30009081: Screenshot 2019-08-06 17.25.25.png | |
| Aug 12 2019, 4:21 PM |
In the context of the mobile Newcomer homepage, light text style in impact, mentor and help module previews feature increased letter-spacing. According to mockup specifications letter-spacing should be zero.
Actual Results:
Expected Results:
.growthexperiments-homepage-module-text-light {
letter-spacing: 0;
}| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Rileych | T213990 [EPIC] Growth: Newcomer homepage | |||
| Resolved | MMiller_WMF | T215983 Homepage: mobile version | |||
| Resolved | • Rileych | T230014 Homepage: layout and UI fixes | |||
| Resolved | BUG REPORT | SBisson | T230364 Homepage: light text style tracking issue in mobile homepage module previews |
There's a letter-spacing: 0.02em rule on these because you asked for it here: T218966#5130398
Should the increased letter spacing continue to be applied on desktop, and only be undone on mobile, or should it be removed completely?
Change 530596 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Remove letter spacing for text light on mobile
Change 530596 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Remove letter spacing for text light on mobile
@RHo - the question above is still unanswered.
On the task screenshot the label "Active ... days ago" (growthexperiments-homepage-mentorship-lastactive) is marked for a change of letter-spacing.
But the fix is applied only to two instances of .growthexperiments-homepage-module-text-light.
growthexperiments-homepage-mentorship-lastactive is still
.growthexperiments-homepage-mentorship-editcount, .growthexperiments-homepage-mentorship-lastactive {
color: #72777d;
font-size: 0.85em;
letter-spacing: 0.02em;The screenshot for
.growthexperiments-homepage-module-mobile-summary .growthexperiments-homepage-module-text-light, .growthexperiments-homepage-module-mobile-details .growthexperiments-homepage-module-text-light, .growthexperiments-homepage-module-mobile-overlay .growthexperiments-homepage-module-text-light {
letter-spacing: 0;
}Hi @SBisson @Catrope - can we remove letter-spacing from all the modules please? It has very marginal benefit considering we are using the standard sans-serif font stack anyway, and in the different languages we have the module, I prefer to not change the letter-spacing from the default of 0 in case of unintended visual effects.
Hi @SBisson @Catrope - can we remove letter-spacing from all the modules please? It has very marginal benefit considering we are using the standard sans-serif font stack anyway, and in the different languages we have the module, I prefer to not change the letter-spacing from the default of 0 in case of unintended visual effects.
Change 531495 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Use only default letter spacing
Change 531495 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Use only default letter spacing