Page MenuHomePhabricator
Create Task
Maniphest T198747

New Pages Feed: implement front-end code for ORES filters
Closed, ResolvedPublic
Actions

Description

This is a task detailing the technical work for front-end changes to the New Pages Feed that will satisfy the requirements in T195927.

  • New Pages Feed: switch filters to a three column layout with two rows.
      • the existing "That" label and filters move to the 2nd row
      • Add "Predicted class" 6 checkboxes and "Predicted issues" 4 checkboxes in row 1, columns 2 and 3. These are added in getTriageTemplatesHTML()
    • AFC: change to 3 column layout with one row
      • "That" label is renamed to "State"
      • Add "Predicted class" 6 checkboxes and "Predicted issues" 4 checkboxes in row 1, columns 2 and 3, in getTriageTemplatesHTML()
    • Nice-to-have, seemingly low level of effort: migrate template code from getTriageTemplatesHTML() into PageTriage/includes/templates/newpagesfeed.mustache
    • Set allowed API params
      • in listControlNav.js getApiParams
      • ensure that filters stick after use, update menuSyncNpp and menuSyncAfc
      • In ApiPageTriageList.php, update getAllowedParams

Details

SubjectRepoBranchLines +/-
Enable PageTriage ORES filters on labs enwikioperations/mediawiki-configmaster+4 -0
Implement ORES filtersmediawiki/extensions/PageTriagemaster+1 K -461
WIP: Implement front-end code for ORES filtersmediawiki/extensions/PageTriagemaster+414 -116
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh triaged this task as Medium priority.Jul 3 2018, 7:00 PM
kostajh created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2018, 7:00 PM
kostajh mentioned this in T195927: New Pages Feed: filtering on ORES scores (3.2).Jul 3 2018, 7:02 PM
kostajh added a comment.Jul 3 2018, 7:28 PM

Noting that there's work happening in T195547 this week that will touch some of the same code.

Aklapper changed the edit policy from "Custom Policy" to "All Users".Jul 4 2018, 3:07 PM
gerritbot subscribed.Jul 4 2018, 5:18 PM

Change 443856 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/PageTriage@master] WIP: Move HTML into Mustache templates

https://gerrit.wikimedia.org/r/443856

gerritbot added a project: Patch-For-Review.Jul 4 2018, 5:18 PM
gerritbot added a comment.Jul 5 2018, 1:08 PM

Change 443966 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/PageTriage@master] WIP: Implement front-end code for ORES filters

https://gerrit.wikimedia.org/r/443966

JTannerWMF added a project: Growth-Team (Sprint 0 (Growth Team)).Jul 5 2018, 5:33 PM
• Catrope edited projects, added Growth-Team, PageTriage; removed Growth-Team (Sprint 0 (Growth Team)), Collaboration-Team-Triage (Collab-Team-This-Quarter).Jul 5 2018, 5:33 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 5 2018, 5:33 PM
JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jul 5 2018, 5:33 PM
JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
• Catrope moved this task from Sprint 0 (Growth Team) to Needs Discussion on the Growth-Team board.Jul 5 2018, 5:34 PM
• Catrope edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).
JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jul 5 2018, 5:35 PM
• Catrope moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 5 2018, 5:38 PM
MMiller_WMF renamed this task from Implement front-end code for ORES filters to New Pages Feed: implement front-end code for ORES filters.Jul 5 2018, 8:51 PM
MMiller_WMF updated the task description. (Show Details)
gerritbot added a comment.Jul 6 2018, 2:12 PM

Change 443966 abandoned by Kosta Harlan:
WIP: Implement front-end code for ORES filters

Reason:
Working on this in 443856

https://gerrit.wikimedia.org/r/443966

SBisson moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 12 2018, 12:50 PM
SBisson removed the point value for this task.
• Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 18 2018, 8:58 AM
gerritbot added a comment.Jul 18 2018, 9:03 AM

Change 443856 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Implement ORES filters

https://gerrit.wikimedia.org/r/443856

MMiller_WMF added subscribers: SBisson, Etonkovidova, • Catrope, MMiller_WMF.Jul 18 2018, 2:37 PM

@Catrope @SBisson @kostajh -- I noticed this task is in @Etonkovidova's column. But I'm not seeing the feature in Beta or Test wiki. Where should Elena be testing it?

kostajh added a comment.Jul 18 2018, 2:48 PM

@MMiller_WMF you need to use this parameter to enable the feature ores=true, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed?ores=true Test wiki doesn't yet have ORES extension enabled (see T199913).

SBisson added a comment.Jul 18 2018, 2:50 PM
In T198747#4434372, @MMiller_WMF wrote:

@Catrope @SBisson @kostajh -- I noticed this task is in @Etonkovidova's column. But I'm not seeing the feature in Beta or Test wiki. Where should Elena be testing it?

The code should be in beta already but needs to be "turned on" with configuration. I can get that in today.

As far as test is concerned, the code will be there with the train next Tuesday.

gerritbot added a comment.Jul 18 2018, 5:09 PM

Change 446624 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[operations/mediawiki-config@master] Enable PageTriage ORES filters on labs enwiki

https://gerrit.wikimedia.org/r/446624

gerritbot added a comment.Jul 19 2018, 8:56 AM

Change 446624 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable PageTriage ORES filters on labs enwiki

https://gerrit.wikimedia.org/r/446624

Etonkovidova added a comment.Jul 25 2018, 10:18 PM

(1) Checked in Chrome, FF, Safari, and IE11 - all layout seems to be correctly display and selection can be done without any visual/functional issues.
Note: I haven't marked the phab ticket checkboxes as Done since the text will be crossed out and greyed out - it might be hard to read.

(2) Filed T200376: New Pages Feed: AfC sorting options are not applicable to some filter selection

Etonkovidova moved this task from QA to Needs PM Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 25 2018, 10:18 PM
MMiller_WMF removed a project: Collaboration-Team-Triage.Jul 30 2018, 9:08 PM
MMiller_WMF closed this task as Resolved.Aug 1 2018, 10:53 PM
MMiller_WMF moved this task from Needs PM Review to Epics In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

@Etonkovidova -- in terms of the front-end layout, and the presence of the right checkboxes and labels, I am all good with this.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits