Add trie level metadata to table blocks and trie catalog #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarohen
requested changes
Mar 10, 2025
| @@ -26,6 +28,16 @@ class LiveTable | |||
| ) : AutoCloseable { | |||
|
|
|||
| private val trieWriter = TrieWriter(al, bp, false) | |||
| private val trieMetadataBuilder = TrieMetadata.newBuilder() | |||
| .setMinValidFrom(MAX_LONG) | |||
There was a problem hiding this comment.
may be able to default these in the protobuf instead...? 🤔
There was a problem hiding this comment.
I put it in the proto for now. The important bit to keep in mind is that if you build a TrieMetadata without calculating anything on it, the contained data doesn't make much sense.
| table-cat/<-table-block | ||
| :current-tries | ||
| (mapv added-trie->edn )))) | ||
| (let [current-tries (->> (.getByteArray bp (util/->path "tables/public$foo/blocks/b01.binpb")) |
There was a problem hiding this comment.
(out of scope of this PR) these are the tests that I'd like us to move to Kotlin too, given the code it's testing is. I understand we don't yet have the same level of fixtures there that we do in Clojure (which is why I have also done the same as you here), so when we next come up for air let's figure out what we need to make this easier
d981abb to
dedb5d9
Compare
dedb5d9 to
b91c0dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #4174. The new metadata is not (yet) used anywhere for pruning.
I am also moving a bunch of bloom logic to Kotlin.
Todo:
recency? wasn't sure if recency still plays a role in the new plans.- Add recency metadata to table-block files #4257
main