feat: Add queryAndParameters to EntitySubscriberInterface afterUpdate and afterSoftRemove
#11117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecsl
commented
Nov 1, 2024
| "private": true, | ||
| "version": "0.3.20", | ||
| "name": "@felipecsl/typeorm", | ||
| "version": "0.3.23", |
There was a problem hiding this comment.
i can revert this before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Right now
EntitySubscriberInterfaceare largely useless when queries are executed viaQueryBuildersince no useful information is passed to the event handlers.I thought it would be useful to at the very least provide the original query and the parameters bound to it, so people could at least parse the query and do something with it.
We found this as a way to unblock ourselves. Could add it to other hooks as well if people are happy with the approach.
Pull-Request Checklist
Partially fixes #2246
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000