make sbt server extensible #3975
Conversation
| */ | ||
|
|
||
| package sbt | ||
|
|
There was a problem hiding this comment.
could you make these sbt.internal.server please so we can break their API, please?
There was a problem hiding this comment.
If we are exposing this out to plugins, then it needs to be public, no?
Are we saying that people can extend it, but the extension is not guaranteed to work down the line?
There was a problem hiding this comment.
yes, it's exposed with 0 compatibility promises. caveat emptor
There was a problem hiding this comment.
I think it's fine if it's presented as an experimental/beta functionality.
| lazy val fallback: ServerHandler = ServerHandler({ handler => | ||
| ServerIntent( | ||
| { case x => handler.log.debug(s"Unhandled notification received: ${x.method}") }, | ||
| { case x => handler.log.debug(s"Unhandled request received: ${x.method}") } |
There was a problem hiding this comment.
any particular reason not to print the whole object like before?
Fixes sbt#3890 Here's an example: ```scala Global / serverHandlers += ServerHandler({ callback => import callback._ import sjsonnew.BasicJsonProtocol._ import sbt.internal.protocol.JsonRpcRequestMessage ServerIntent( { case r: JsonRpcRequestMessage if r.method == "lunar/helo" => jsonRpcNotify("lunar/oleh", "") () }, PartialFunction.empty ) ```
|
woohoo! |
|
sorry I only realised during the sbt meeting that you'd pushed the last commit 2 days ago.. :-/ |
|
This is a good first step to have bsp support in sbt, thanks for doing it. 👍 |
|
Hasn't this been released in an sbt version? This is blocking me from implementing a bsp prototype in sbt. |
|
@eed3si9n Would be really helpful if we can get this in a release soon so that I can work on the bsp prototype plugin ^^ |
|
Yea. We'll try to get some 1.2.0 milestone out soonish. |
Fixes #3890
Here's an example: