Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mysql2 0.4.0, first release with prepared statements support #21536

Merged
merged 1 commit into from
Sep 8, 2015
Merged

Support mysql2 0.4.0, first release with prepared statements support #21536

merged 1 commit into from
Sep 8, 2015

Conversation

jeremy
Copy link
Member

@jeremy jeremy commented Sep 7, 2015

Broadens AR gem requirement from ~> 0.3.18 to >= 0.3.18, < 0.5

Known failure on Ruby 2.3/trunk: brianmario/mysql2#671

@rails-bot
Copy link

r? @carlosantoniodasilva

(@rails-bot has picked a reviewer for you, use r? to override)

@jeremy
Copy link
Member Author

jeremy commented Sep 8, 2015

Unrelated build failure with SassImporter: https://travis-ci.org/rails/rails/jobs/79201176#L841-L842

@rafaelfranca
Copy link
Member

Yeah. Already working in a fix.

@rafaelfranca
Copy link
Member

Fixed

@rafaelfranca
Copy link
Member

:shipit:

jeremy added a commit that referenced this pull request Sep 8, 2015
@jeremy
Merge pull request #21536 from jeremy/support-mysql2-0.4.0
81dd387 
Support mysql2 0.4.0, first release with prepared statements support
@jeremy jeremy merged commit 81dd387 into rails:master Sep 8, 2015
@jeremy jeremy deleted the support-mysql2-0.4.0 branch September 8, 2015 00:51
sodabrew
sodabrew reviewed Sep 8, 2015
View reviewed changes
Gemfile
@@ -90,7 +90,7 @@ platforms :ruby do
group :db do
gem 'pg', '>= 0.18.0'
gem 'mysql', '>= 2.9.0'
gem 'mysql2', '>= 0.3.18'
gem 'mysql2', '>= 0.4.0', github: 'brianmario/mysql2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the github reference required so that ruby-head tests pass?

@sodabrew
Copy link
Contributor

sodabrew commented Sep 8, 2015

@jeremy Added a few comments post-merge, we can pick this or another issue to follow-up on :)

@sodabrew sodabrew mentioned this pull request Sep 8, 2015
Closed
@jeremy
Copy link
Member Author

jeremy commented Sep 8, 2015

The github ref is because it was just before you pushed a gem :) Will
update. Backporting should be fine.
On Tue, Sep 8, 2015 at 03:27 Aaron Stone notifications@github.com wrote:

@jeremy https://github.com/jeremy Added a few comments post-merge, we
can pick this or another issue to follow-up on :)

—
Reply to this email directly or view it on GitHub
#21536 (comment).

@drench drench mentioned this pull request Nov 2, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@carlosantoniodasilva carlosantoniodasilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeremy @rails-bot @rafaelfranca @sodabrew @carlosantoniodasilva