-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to wgpu-native 24.0.0.2 #673
Conversation
made some more progress... will try to keep at it but now run into the surface stuff which gave some trouble last time and is also really OS specific. It might be worth to automatically generate the code for all these |
all the examples have passed today, also most tests. |
Thanks for this amazing piece of work @Vipitis! This was not a small update 😉. I have read through all the changes, and made myself a list to look at some points more closely. I'll just push to this branch. |
This is ready from my end. I ran the tests, examples, also for pygfx, on MacOS, WIndows, and Linux, and all is looking good! |
@Vipitis feel free to comment on my changes. Let's not merge this until you're happy too. |
@almarklein thanks for the improvements. I followed this closely and it looks good to me! Regarding the difference between null string and empty string: there is no test that specifically requires the empty string, not sure where this would even be the case. when not specifying an entry point for example you specifically need it to be this null string. Perhaps empty string is more of an output use case for For the view usages I branched off my example and will modify it in the next couple of days to test and show it's functionality and then hopefully have it in shadertoy soon. |
I guess the behavior depends on the case. Thinking of it, maybe it would be cleaner to also use the null-string if no label is provided. As for the |
@Korijn This is ready from our (Jan and me) end 🚀 |
Let's make a release real soon. I'll have a quick look a updating idl. |
Again trying to start the work on this... (in progress and will be draft for a while)
there is a release for 24.0.0.1 but wgpu23 never had a release for wgpu-native.
I am mainly motivated by the inclusion of gfx-rs/wgpu#6755
useful links:
wgpu-native
?)from template (skip upstream and IDL):
python tools/download_wgpu_native.py --version xx
to download the latest webgpu.h and DLL.python codegen
to apply the automatic patches to the code.hparser.py
to adjust to new formatting.wgpu_native/_api.py
to get an idea of what structs and functions have changed._api.py
:* Apply any necessary changes.
* Remove the FIXME comment if no further action is needed, or turn into a TODO for later.
python codegen
again to validate that all is well. Repeat the steps above if necessary.Wrapping up
API changes
Nope. The
compilation_hints
arg got removed, but we did not support that anyway.