Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kerberos Request Options to Examples #1905

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Kerberos Request Options to Examples #1905

wants to merge 5 commits into from

Conversation

p0rtL6
Copy link
Contributor

@p0rtL6 p0rtL6 commented Feb 25, 2025

This branch exposes functionality to change the options on Kerberos requests. Originally taken from Orpheus. The functionality has been added to the underlying functions, and has been propagated up to the command line examples that use it. There has also been an example added that can generate the option codes that are used by the examples (follows the same format as Orpheus).

Examples updated:

  • GetUserSPNs.py
  • addcomputer.py
  • dacledit.py
  • getPac.py
  • getST.py
  • getTGT.py
  • goldenPac.py
  • owneredit.py
  • raiseChild.py
  • rbcd.py
  • ticketer.py

Added:

  • GenerateKerberosOptions.py

Modified Libraries:

  • kerberosv5.py

The above is copied from the updated README file for this branch, if merged, the README will need to be updated.

@gabrielg5 gabrielg5 added the in review This issue or pull request is being analyzed label Mar 11, 2025
@gabrielg5
Copy link
Collaborator

Been checking this one... there is a license issue with proposed changes.

As it has been taken from a repository with no-license, almost every action is not allowed in that code (I guess one is not even allowed to use that software without a license)

They can upload those changes as a PR in impacket... or create a PR in the other repository for them to add a compatible license to it

@gabrielg5 gabrielg5 added the low Low priority item label Mar 13, 2025
@p0rtL6
Copy link
Contributor Author

p0rtL6 commented Mar 13, 2025

I see. I can try and ask for a license to be added, but it seems to be abandoned with an open issue about a license.

If it helps at all to clarify, the changes I submitted in this pull request are for the most part original code, not copied from Orpheus:

  • The GenerateKerberosOptions.py tool is completely rewritten and should not contain any of the code from Orpheus, it just generates the same format.
  • The changes to Kerberosv5.py contain a couple of lines that are taken directly from Orpheus, the lines specifically dealing with setting the encryption type are identical. The rest of the changes, including the other options, should be completely new additions.
  • There are also a couple lines in GetUserSPNs.py that are identical (things for the encryption type) but the other additions should also be different.

If a license cannot be added, is there any way to move forward with these changes, or is it completely dead in the water? I can rewrite changes to be different, but I do not know if that really solves the problem...

@p0rtL6 p0rtL6 mentioned this pull request Mar 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in review This issue or pull request is being analyzed low Low priority item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0rtL6 @gabrielg5