Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts "[web][a11y]Delete _childContainerElement (#163662)" #165416

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Mar 18, 2025

Reverts: #163662

Initiated by: hannah-hyj

Reason for reverting: google 3 failure

Original PR Author: hannah-hyj

Reviewed By: {yjbanov}

This change reverts the following previous change:
delete _childContainerElement , add the rect compensate and scrolling adjustment to the children

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Mar 18, 2025
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. platform-web Web applications specifically labels Mar 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 18, 2025
Merged via the queue into master with commit 4e5a2db Mar 18, 2025
9 of 11 checks passed
@auto-submit auto-submit bot deleted the revert_6e74ee483380f2d8ec77f08ce23f891af9a03933 branch March 18, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. f: scrolling Viewports, list views, slivers, etc. platform-web Web applications specifically revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants