[Impeller] Move skia_conversions towards retirement #165408
Conversation
|
What's left?
One thing is for sure - the name |
| @@ -34,6 +34,31 @@ using DlRect = flutter::DlRect; | |||
| using DlIRect = flutter::DlIRect; | |||
| using DlPath = flutter::DlPath; | |||
|
|
|||
| void Paint::ConvertStops(const flutter::DlGradientColorSourceBase* gradient, | |||
There was a problem hiding this comment.
We should really do the stop conversion when we record the gradient instead of on each dispatch.
There was a problem hiding this comment.
So, move this logic into DL? We could do it when the DlObject is created from Flutter since I don't think there is read back of the stops once Flutter makes one.
There was a problem hiding this comment.
Yeah that SG. We already copy from dart:ui into display list, so the conversion can be done there. Technically this is the same conversion skia does when we dispatch to it, so there should be no change in behavior.
|
autosubmit label was removed for flutter/flutter/165408, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
The skia_conversions sources and namespace have been filled with methods that are no longer used now that the DisplayList has its own complete set of APIs and is now mostly obsolete.