Update tests to use Xcode 16.2 and iOS 18.2 Simulator #165318
Conversation
| // means the runtime was either bundled with Xcode, exactly matched your SDK | ||
| // version, or it's indicated a better match for your SDK. | ||
| final Map<String, Object?> decodeResult = | ||
| json.decode(runtimesForSelectedXcode) as Map<String, Object?>; | ||
| final String? iosKey = | ||
| decodeResult.keys.where((String key) => key.contains('iphoneos')).firstOrNull; | ||
| final String? runtimeBuildForSelectedXcode = switch (decodeResult[iosKey]) { | ||
| {'userOverriddenBuild': final String build} => build, |
There was a problem hiding this comment.
Xcode 16.2 is weird in that it originally shipped with iOS 18.2 (22C150), but later the "preferredBuild" became 18.3.1 (22D8075). mac_toolchain is still using iOS 18.2 and sets it as the override build. This will make Flutter tests using a simulator use the override version if set.
This was causing a flaky error: https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20module_test_ios/3351/overview
| @@ -370,6 +370,7 @@ public class $pluginClass: NSObject, FlutterPlugin { | |||
| destination: 'platform=macOS', | |||
| configuration: 'Debug', | |||
| testName: 'native_plugin_unit_tests_macos', | |||
| extraOptions: <String>['-parallel-testing-enabled', 'NO'], | |||
There was a problem hiding this comment.
This is potential fix for #164902:
Tests indicate it seem to be effective:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20plugin_test_macos/27007/overview
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20plugin_test_macos/7/overview
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20plugin_test_macos/6/overview
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20plugin_test_macos/8/overview
Runs tests on Xcode 16.2 and iOS 18.2. Also updates engine scenario golden files to iOS 18.2 and removes non-impeller (Skia) test files that we no longer use.
All framework tests passing: #148899 (comment)
All engine tests passing: #148906 (comment)
Fixes #148907 and #148957.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.