Add missing Dart SDK dependencies to DEPS #165308
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been validated against the dart revision e4a852ed1e96d8ec8b07a248495645965b39c05a that contains the commit of https://dart-review.googlesource.com/c/sdk/+/397164. |
aam
approved these changes
Mar 17, 2025
|
autosubmit label was removed for flutter/flutter/165308, because - The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/165308, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
The Google Testing step is failing on a 404 trying to download canvaskit. To get past it, you can set the "Infra failure" label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow https://dart-review.googlesource.com/c/sdk/+/397164 to reland.
Using
pub getin the sdk requires all packages to resolve to actual paths.It seems the flutter DEPS file had fallen behind.