Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix crash on some key repeat events #165307

Merged
merged 1 commit into from
Mar 18, 2025
Merged

[Android] Fix crash on some key repeat events #165307

merged 1 commit into from
Mar 18, 2025
+63 −1

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Mar 17, 2025 •
edited
Loading

Description

This PR fixes a crash on Android related to specific keyboard events.
It is very similar to http://github.com/flutter/engine/issues/35924 which was related to down events. This PR fixes the similar logic related to repeat events.

Related Issue

Fixes Flutter 3.29 Fatal crash with java.lang.AssertionError

Tests

Adds 1 test.

@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine repository. See also e: labels. labels Mar 17, 2025
@bleroux bleroux changed the title {Android] Fix crash on some key repeat events [Android] Fix crash on some key repeat events Mar 17, 2025
@bleroux bleroux requested a review from dkwingsmt March 17, 2025 20:46
dkwingsmt
dkwingsmt approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what a case! Thank you!

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 18, 2025
Merged via the queue into flutter:master with commit d0ef1c1 Mar 18, 2025
168 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@bleroux bleroux deleted the fix_android_crash_on_key_repeat_event_having_zeroed_scan_code branch March 18, 2025 21:53
@Piinks Piinks mentioned this pull request Mar 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. platform-android Android applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter 3.29 Fatal crash with java.lang.AssertionError
2 participants
@bleroux @dkwingsmt