Add more visual feedback to Slider with slideOnly interaction #165306
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sliders with `allowedInteraction: SliderInteraction.slideOnly` gave no interaction feedback, if they are grabbed and moved along the track instead of the handle, despite having the exact same behaviour otherwise. With this change, the handle becomes "active" (elevate+overlay) as soon, as the track is tapped.
e05b7e4 to
912ca89
Compare
|
I can add tests, if I get a positive feedback on even including this change. But in my opinion this change is exempt worthy, because it changes the behavior to be more in line with the rest of the |
Sliders with
allowedInteraction: SliderInteraction.slideOnlygave no interaction feedback, if they are grabbed and moved along the track instead of the handle, despite having the exact same behaviour otherwise.With this change, the handle becomes "active" (elevate+overlay) as soon, as the track is tapped.
Fixes #165304
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.