Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize path before searching for package config #165392

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Normalize path before searching for package config #165392

merged 1 commit into from
Mar 20, 2025
+10 −1

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Mar 18, 2025

If we don't normalize the .absolute.path will look like /child/.
And Directory('/child/.').parent is Directory('/child).

@sigurdm sigurdm requested a review from matanlurey March 18, 2025 12:38
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 18, 2025
@sigurdm sigurdm mentioned this pull request Mar 18, 2025
Open
matanlurey
matanlurey approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sigurdm sigurdm added this pull request to the merge queue Mar 20, 2025
Merged via the queue into flutter:master with commit 95843ca Mar 20, 2025
133 checks passed
@sigurdm sigurdm deleted the normalize_dir_for_finding_package_config branch March 20, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sigurdm @matanlurey