Fix CODEOWNERS after monorepo merge #165217
Open
+10
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
Mar 14, 2025
|
I wonder if you could have removed the "/" from the start of the lines and gotten the same effect. |
|
@jtmcdole Sadly that wouldn't work, see the description above:
|
vashworth
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub's CODEOWNERS feature picks the first file it finds in the root,
.github/, ordocs/directory. GitHub does not support nested CODEOWNERS files.For example, this PR updates the embedder API but did not request reviews from the embedder API reviewers: #164577
To fix this, this merges all
CODEOWNERSfiles to the root of the repo.cc @cbracken @chinmaygarde @jmagman as you are added as CODEOWNERS.