Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Java Versions to 21 on CI #165210

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Update Java Versions to 21 on CI #165210

wants to merge 13 commits into from

Conversation

jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Mar 14, 2025 •
edited
Loading

Updated java versions to 21 on CI. Monitor to see if anything breaks.

Fixes #163158

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jesswrd jesswrd changed the title Updated Java Versions to 21 on CI Update Java Versions to 21 on CI Mar 18, 2025
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 18, 2025
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Mar 20, 2025
@jesswrd jesswrd marked this pull request as ready for review March 21, 2025 16:59
@jesswrd jesswrd requested a review from matanlurey as a code owner March 21, 2025 16:59
@jesswrd jesswrd requested a review from reidbaker March 21, 2025 16:59
reidbaker
reidbaker reviewed Mar 21, 2025
View reviewed changes
packages/integration_test/example/android/gradle.properties Outdated
@@ -1,4 +1,4 @@
org.gradle.jvmargs=-Xmx8G -XX:MaxMetaspaceSize=4G -XX:ReservedCodeCacheSize=512m -XX:+HeapDumpOnOutOfMemoryError
org.gradle.jvmargs=-Xmx8G -XX:MaxMetaspaceSize=4G -XX:ReservedCodeCacheSize=512m -XX:+HeapDumpOnOutOfMemoryError -XX:+EnableDynamicAgentLoading
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problem does EnableDynamicAgentLoading fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supposed to potentially get rid of a warning, but it didn't. Removed.

packages/integration_test/example/android/project-app.lockfile Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was part of debugging a test failure related to depending on an older version of mockito that was incompatible with java 21. This lockfile can be added back without errors.

packages/integration_test/example/android/project-integration_test.lockfile Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was part of debugging a test failure related to depending on an older version of mockito that was incompatible with java 21. This lockfile as is causes failures. It needs to be regenerated.

...s/test/integration.shard/android_gradle_legacy_flutter_plugins_strings_in_comments_test.dart Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmackall do you remember what "legacy" was supposed to test? I dont remember if this test requiring is a sign that we will break users or if it was testing the legacy path of something else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No but at a glance I would guess it is a test of this code path
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy#L490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker left review comments

@gmackall gmackall gmackall left review comments

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit Java 21 support and update ci to Java 21
4 participants
@jesswrd @matanlurey @reidbaker @gmackall