Port FlutterTask from Groovy to Kotlin
#165244
Conversation
packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginConstants.kt
Outdated
Show resolved
Hide resolved
| * Base implementation of a Gradle task. Gradle tasks can not be instantiated for testing, | ||
| * so this class delegates all logic to [BaseFlutterTaskHelper]. | ||
| * | ||
| * IMPORTANT: Do not add logic to the methods in this class directly, |
There was a problem hiding this comment.
ktdoc nit: /** is used for comments shown to callers of this class. // (or /* */) Is normally used for maintainers or people reading the implementation.
I don't think it needs to be changed in this pr but wanted to use this opportunity to share the difference.
javadoc
https://engdoc.corp.google.com/eng/doc/devguide/java/style/index.md?cl=head#s7-javadoc
vs
Implementation comments
https://engdoc.corp.google.com/eng/doc/devguide/java/style/index.md?cl=head#s4.8.6-comments
There was a problem hiding this comment.
I did not know this, thanks. Will change
|
autosubmit label was removed for flutter/flutter/165244, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/165244, because - The status or check suite Mac tool_integration_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
FlutterTaskfrom groovy to kotlinBaseFlutterTaska bit, to follow a paradigm that methods onBaseFlutterTaskandFlutterTaskwill contain no logic, and instead be set equal to a method with the same name inBaseFlutterTaskHelperandFlutterTaskHelperrespectively, and that both of those helpers will be stateless. This allows us to somewhat get around the fact that you cannot create aTaskinstance in testing, because testing the logic of the task is the same as testing the logic of the helper.FlutterPluginConstantsobject to hold the constants fromFlutterPlugin. I think ideally this will be collapsed back in toFlutterPluginwhen the conversion is completed, but it needs to be moved for now so it can be referenced in Kotlin code (this pr needs it).Fixes #162112
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.