Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_releases] Flutter stable 3.29.0 engine version change #165139

Conversation

reidbaker
Copy link
Contributor

Only the engine version change.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@reidbaker reidbaker requested a review from zanderso March 13, 2025 18:42
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the right commit to me!

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
Copy link
Contributor

auto-submit bot commented Mar 13, 2025

autosubmit label was removed for flutter/flutter/165139, because - The status or check suite Mac_arm64 run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@reidbaker
Copy link
Contributor Author

Seeing failure to download errors. My current guess is that I need to wait for 18b71d6 post submits to finish.

https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=flutter-3.29-candidate.0&hashFilter=18b71d647a292a980abb405ac7d16fe1f0b20434&showBringup=true

@matanlurey matanlurey added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Mar 13, 2025
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@matanlurey
Copy link
Contributor

presubmit-exempt: We are merging on red to verify via posubmit instead, because this was branched on January 15th and the most recent changes for versioning infrastructure was certainly much later than that, so that is worth mentioning off the bat:

image

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@auto-submit auto-submit bot merged commit c236373 into flutter:flutter-3.29-candidate.0 Mar 13, 2025
128 of 150 checks passed
@reidbaker reidbaker deleted the cherrypicks-flutter-3.29-candidate.0 branch March 13, 2025 20:18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App emergency Jump the queue; land PR in front of all others; only use for emergencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants