Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arrowHeadColor breaks differentiation between states #165178

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Fix arrowHeadColor breaks differentiation between states #165178

merged 1 commit into from
Mar 17, 2025
+9 −5

Conversation

huycozy
Copy link
Member

@huycozy huycozy commented Mar 14, 2025

Fix #160458

The arrowheads color is currently displayed wrong when passing arrowHeadColor parameter, it's due to the arrowHeadColor is passing to IconButton.icon widget, not IconButton.color itself. Meanwhile, the IconButton state depends on onPressed callback and the button color logic happens in IconButton, not in Icon widget. The fix is simply to pass arrowHeadColor to IconButton so that buttons will be displaying correct color when state changes.

before after
before.mov
after.mov

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@huycozy huycozy self-assigned this Mar 14, 2025
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 14, 2025
@huynguyennovem huynguyennovem force-pushed the PaginatedDataTable-correct-arrowHeadColor-160458 branch from 599b28d to 9c27620 Compare March 14, 2025 08:31
@huycozy
Fix arrowHeadColor breaks differentiation between states
22247b3 
Signed-off-by: huycozy <huy@nevercode.io>
@huynguyennovem huynguyennovem force-pushed the PaginatedDataTable-correct-arrowHeadColor-160458 branch from 9c27620 to 22247b3 Compare March 14, 2025 10:18
bleroux
bleroux approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Let's see if it breaks some Google tests.

@huycozy huycozy added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 17, 2025
Merged via the queue into flutter:master with commit 51bf72a Mar 17, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2025
@huycozy huycozy deleted the PaginatedDataTable-correct-arrowHeadColor-160458 branch March 18, 2025 02:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2025
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025
@engine-flutter-autoroll
51bf72afa Fix arrowHeadColor breaks differentiation between states (f…
cf23b24 
…lutter/flutter#165178)
@Piinks Piinks mentioned this pull request Mar 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroux bleroux bleroux approved these changes

Assignees

@huycozy huycozy

Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PaginatedDataTable: arrowHeadColor breaks differentiation between states (enabled/disabled)
2 participants
@huycozy @bleroux