[Impeller] Enable mediatek on API 34+. #165156
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
tested: all of the mokey tests are APi 34 and mediatek, so they will switch back to Vulkan. |
|
That link doesn't work for me, it says "Error parsing source file format. ✗" |
|
Click toggle chart style? works ok for me |
| if (api_level < kMinimumAndroidApiLevelForMediaTekVulkan && | ||
| __system_property_find("ro.vendor.mediatek.platform") != nullptr) { |
There was a problem hiding this comment.
Should we be using VkPhysicalDeviceProperties to determine this?
There was a problem hiding this comment.
This is more about the SoC than the GPU driver. early mediatek seems to have equal opportunity bugs.
That's the ticket! |
|
autosubmit label was removed for flutter/flutter/165156, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Most of the reported Mediatek issues are API 29/30, maybe up to 31. By 34 it should work, and the mokey device we have works fine with Vulkan and runs on CI. This is necessary to allow MediaTek devices to use HCPP without us having to write a new rendering surface abstraction for GL.
This does not enable PowerVR, which is still denylisted in the vulkan backend.