Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): check for remaining relevant text direction properties #165028

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Goddchen
Copy link
Contributor

@Goddchen Goddchen commented Mar 12, 2025

We faced an issue that the assert at https://github.com/flutter/flutter/blob/3.29.1/packages/flutter/lib/src/semantics/semantics.dart#L497-L500 was triggering although our widget was placed under a MaterialApp and therefore had a text direction set.

Turns out that _getTextDirection() just was not checking for attributedValue, etc.

Related issue: #165051

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Signed-off-by: Goddchen <goddchen@gmail.com>
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 12, 2025
@lColinDl
Copy link

Here's a standalone test to reproduce the bug and verify that it's fixed:

testWidgets('semantics with attributed value should not fail',
    (tester) async {
  await tester.pumpWidget(
    MaterialApp(
      home: Semantics(
        attributedValue: AttributedString('test value'),
        child: const Placeholder(),
      ),
    ),
  );
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants