Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_tools] Call reassemble with DWDS 24.3.7 and update hot reload and restart analytics #165006

Merged
merged 3 commits into from
Mar 12, 2025
Merged

[flutter_tools] Call reassemble with DWDS 24.3.7 and update hot reload and restart analytics #165006

merged 3 commits into from
Mar 12, 2025
+280 −58

Conversation

srujzs
Copy link
Contributor

@srujzs srujzs commented Mar 11, 2025 •
edited
Loading

dart-lang/webdev#2584

Reassemble was being called in DWDS in the injected client until v24.3.7. Flutter tools should now instead be the one to call the service extension. Now that it's in Flutter tools, we can also report how long it took. Similarly, we should update analytics on various things like, whether there was a reload rejection, how long the compile took, and more.

Adds test to check that these analytics are being reported correctly.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@srujzs
[flutter_tools] Call reassemble with DWDS 24.3.7 and update hot reloa…
9fd319c 
…d and restart analytics

Reassemble was being called in DWDS in the injected client until v24.3.7.
Flutter tools should now instead be the one to call the service extension.
Now that it's in Flutter tools, we can also report how long it took.
Similarly, we should update analytics on various things like, whether
there was a reload rejection, how long the compile took, and more.

Adds test to check that these analytics are being reported correctly.
@srujzs srujzs requested review from nshahan and jyameo March 11, 2025 18:23
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 11, 2025
jyameo
jyameo approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srujzs srujzs added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025
@srujzs
Copy link
Contributor Author

srujzs commented Mar 12, 2025

Thanks!

@auto-submit auto-submit bot added this pull request to the merge queue Mar 12, 2025
Merged via the queue into flutter:master with commit 0bdb4d6 Mar 12, 2025
133 of 134 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
c32ac88 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
fd6ec7d 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
5267bbe 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
f8ff53c 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
ce77d13 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
c3a9ab9 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
a4556d6 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
001bf62 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
3082dff 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
dbb0497 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
777dc78 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
53f8af5 
… hot reload and restart analytics (flutter/flutter#165006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
cbb0457 
… hot reload and restart analytics (flutter/flutter#165006)
This was referenced Mar 13, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
9ce8675 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
a3f0291 
… hot reload and restart analytics (flutter/flutter#165006)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
cd84e38 
… hot reload and restart analytics (flutter/flutter#165006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
6721ca3 
… hot reload and restart analytics (flutter/flutter#165006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
1684ef8 
… hot reload and restart analytics (flutter/flutter#165006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
27f7b79 
… hot reload and restart analytics (flutter/flutter#165006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
a3a9bc1 
… hot reload and restart analytics (flutter/flutter#165006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
ec8a81c 
… hot reload and restart analytics (flutter/flutter#165006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
d361905 
… hot reload and restart analytics (flutter/flutter#165006)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025
@engine-flutter-autoroll
0bdb4d68b [flutter_tools] Call reassemble with DWDS 24.3.7 and update…
9944a03 
… hot reload and restart analytics (flutter/flutter#165006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyameo jyameo jyameo approved these changes

@nshahan nshahan Awaiting requested review from nshahan

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srujzs @jyameo