Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Change fallback behavior for devices pre API 29 to Skia regardless of Impeller state. #165090

Merged
merged 1 commit into from
Mar 13, 2025
Merged

[CP] Change fallback behavior for devices pre API 29 to Skia regardless of Impeller state. #165090

merged 1 commit into from
Mar 13, 2025

Conversation

jonahwilliams
Copy link
Member

CP of #165075

There are currently a large amount of crashes coming from older devices that we don't have good test coverage for. For now, lets remove the fallback to ImpellerGLES on old devices and instead use SkiaGLES, which we know from experience works on these older devices.

@jonahwilliams jonahwilliams added the cp: stable cherry pick this pull request to stable release candidate branch label Mar 12, 2025
@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine repository. See also e: labels. labels Mar 12, 2025
@jonahwilliams jonahwilliams added cp: review Cherry-picks in the review queue and removed platform-android Android applications specifically engine flutter/engine repository. See also e: labels. labels Mar 12, 2025
@jonahwilliams jonahwilliams requested a review from jtmcdole March 12, 2025 22:37
jtmcdole
jtmcdole approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reidbaker - I don't know if I have any goodwill tokens to burn, but this would be one to burn it on.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@auto-submit auto-submit bot merged commit 70bd597 into flutter:flutter-3.29-candidate.0 Mar 13, 2025
150 checks passed
@reidbaker
Copy link
Contributor

Accepted but I need a changelog entry from yall

@jonahwilliams
Copy link
Member Author

on it

@jonahwilliams
Copy link
Member Author

#165101

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
70bd597db [CP] Change fallback behavior for devices pre API 29 to Ski…
40d7e52 
…a regardless of Impeller state. (flutter/flutter#165090)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
70bd597db [CP] Change fallback behavior for devices pre API 29 to Ski…
00aec03 
…a regardless of Impeller state. (flutter/flutter#165090)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
70bd597db [CP] Change fallback behavior for devices pre API 29 to Ski…
c1d4790 
…a regardless of Impeller state. (flutter/flutter#165090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue cp: stable cherry pick this pull request to stable release candidate branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahwilliams @reidbaker @jtmcdole