[Impeller] Pixel snap perfectly horizontal or vertical lines. #165079
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
MSAA anti aliasing is not gamma correct. even though we always cover a minimum of 4 samples, there is a visible difference between covering the same 4 samples or split 2/2 in adjacent pixels (or 4/4).
To work around this, for perfectly horizontal and vertical lines (which are common in borders). We can snap them to the nearest physical pixels.