Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] fix missing glyph error. #165055

Merged
merged 5 commits into from
Mar 13, 2025
Merged

[CP] fix missing glyph error. #165055

merged 5 commits into from
Mar 13, 2025

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Mar 12, 2025 •
edited
Loading

Cherry pick fix of #164606 .

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 12, 2025
@jonahwilliams jonahwilliams marked this pull request as ready for review March 12, 2025 14:49
@jonahwilliams jonahwilliams requested a review from jtmcdole March 12, 2025 14:49
@jonahwilliams jonahwilliams added cp: review Cherry-picks in the review queue cp: stable cherry pick this pull request to stable release candidate branch labels Mar 12, 2025
@reidbaker reidbaker self-requested a review March 12, 2025 17:55
reidbaker
reidbaker approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release engineer approval. Still need content/correctness approval.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Mar 12, 2025

autosubmit label was removed for flutter/flutter/165055, because - The status or check suite Linux linux_web_engine_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@auto-submit auto-submit bot merged commit b37d0b7 into flutter:flutter-3.29-candidate.0 Mar 13, 2025
150 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
b37d0b752 [CP] fix missing glyph error. (flutter/flutter#165055)
dc97372
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
b37d0b752 [CP] fix missing glyph error. (flutter/flutter#165055)
c92fb9e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
b37d0b752 [CP] fix missing glyph error. (flutter/flutter#165055)
7358f29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue cp: stable cherry pick this pull request to stable release candidate branch e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahwilliams @reidbaker @jtmcdole