Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP][Impeller] handle failure of allocation of surface for toImage/toImageSync #164938

Merged
merged 4 commits into from
Mar 11, 2025
Merged

[CP][Impeller] handle failure of allocation of surface for toImage/toImageSync #164938

merged 4 commits into from
Mar 11, 2025
+20 −1

Conversation

jonahwilliams
Copy link
Member

FIxes #164628

@jonahwilliams
[Impeller] test empty snapshot and allocation failure. (flutter#164668)
136ff4f 
Speculative fix for flutter#164628

If our render target allocation failed, we need to bail out of toImage
so that we don't crash. Adds a test that simulates this by asking for a
0x0 texture.
@jonahwilliams
Add changelog entry.
aeaaed1
@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 10, 2025
@jonahwilliams jonahwilliams requested a review from jtmcdole March 10, 2025 21:43
@jonahwilliams jonahwilliams added cp: review Cherry-picks in the review queue cp: stable cherry pick this pull request to stable release candidate branch labels Mar 10, 2025
jtmcdole
jtmcdole approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm-seinfeld

@reidbaker reidbaker self-requested a review March 11, 2025 16:38
@reidbaker
Copy link
Contributor

@jonahwilliams can you confirm this is an ios only fix?

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2025
@auto-submit auto-submit bot merged commit bd5f992 into flutter:flutter-3.29-candidate.0 Mar 11, 2025
150 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
bd5f99208 [CP][Impeller] handle failure of allocation of surface for …
f25d50c 
…toImage/toImageSync (flutter/flutter#164938)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
bd5f99208 [CP][Impeller] handle failure of allocation of surface for …
7434cf5 
…toImage/toImageSync (flutter/flutter#164938)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
bd5f99208 [CP][Impeller] handle failure of allocation of surface for …
c431769 
…toImage/toImageSync (flutter/flutter#164938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue cp: stable cherry pick this pull request to stable release candidate branch e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahwilliams @reidbaker @jtmcdole