Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web_ui] Tighten up font fallback code #164951

Merged
merged 2 commits into from
Mar 11, 2025
Merged

[web_ui] Tighten up font fallback code #164951

merged 2 commits into from
Mar 11, 2025
+40 −52

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Mar 11, 2025

Make one type and many members private
Make some fields final

@kevmoo
[web_ui] Tighten up font fallback code
c230121 
Make one type and many members private
Make some fields final
@kevmoo kevmoo requested a review from mdebbar March 11, 2025 00:40
@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. platform-web Web applications specifically labels Mar 11, 2025
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2025
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Mar 11, 2025

autosubmit label was removed for flutter/flutter/164951, because - The status or check suite Mac build_android_host_app_with_module_aar has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 11, 2025
Merged via the queue into flutter:master with commit 8821a27 Mar 11, 2025
170 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2025
@kevmoo kevmoo deleted the web_engine_font_cleanup branch March 11, 2025 20:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
4d2015c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
21e5f79 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
f217cab 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
06b98e5 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
922e321 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
3766531 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
2de7e63 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
41aa7f7 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
4f7de16 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
7aceb83 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
081c263 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
62fd54b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
3152e46 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
80ab44c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
42d7c7f 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
d6417e2 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
2081819 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
21232a8 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
874fab0 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
a36b3e6 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
8b14454 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
ee54dcf 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
1a50048 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025
@engine-flutter-autoroll
8821a27de [web_ui] Tighten up font fallback code (flutter/flutter#164951
647cdc8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebbar mdebbar mdebbar approved these changes

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @mdebbar