Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Engine][iOS] Cancel animation when recieved UIKeyboardWillHideNotification with duration 0.0 #164884

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Engine][iOS] Cancel animation when recieved UIKeyboardWillHideNotification with duration 0.0 #164884

wants to merge 2 commits into from
+78 −1

Conversation

koji-1009
Copy link
Contributor

@koji-1009 koji-1009 commented Mar 9, 2025 •
edited
Loading

fix #112281

The event log output shows that UIKeyboardWillHideNotification occurs immediately after UIKeyboardWillShowNotification. However, the animation is not cancelled in response to UIKeyboardWillHideNotification.

This PR adds animation cancellation processing in response to UIKeyboardWillHideNotification with duration 0.0.

after.mp4

test app: https://github.com/koji-1009/pm_behavior_test

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-ios iOS applications specifically engine flutter/engine repository. See also e: labels. team-ios Owned by iOS platform team labels Mar 9, 2025
@koji-1009 koji-1009 changed the title fix: Cancel animation when recieved UKEYeboardWillHideNotification fix: Cancel animation when recieved UIKeyboardWillHideNotification Mar 9, 2025
@koji-1009 koji-1009 force-pushed the fix/ios_keyboard branch 2 times, most recently from dbb27ec to 2461b10 Compare March 10, 2025 15:14
@koji-1009 koji-1009 marked this pull request as ready for review March 10, 2025 15:22
@koji-1009 koji-1009 changed the title fix: Cancel animation when recieved UIKeyboardWillHideNotification [Engine][iOS] Cancel animation when recieved UIKeyboardWillHideNotification Mar 10, 2025
@koji-1009 koji-1009 force-pushed the fix/ios_keyboard branch 3 times, most recently from 3dd46d9 to 92bb123 Compare March 10, 2025 23:13
@koji-1009 koji-1009 marked this pull request as draft March 10, 2025 23:13
@koji-1009 koji-1009 marked this pull request as ready for review March 11, 2025 02:35
@koji-1009 koji-1009 changed the title [Engine][iOS] Cancel animation when recieved UIKeyboardWillHideNotification [Engine][iOS] Cancel animation when recieved UIKeyboardWillHideNotification with duration 0.0 Mar 12, 2025
@chinmaygarde
Copy link
Member

cc @vashworth perhaps?

vashworth
vashworth approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@vashworth vashworth requested a review from luckysmg March 22, 2025 00:26
luckysmg
luckysmg approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@luckysmg luckysmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckysmg luckysmg luckysmg approved these changes

@vashworth vashworth vashworth approved these changes

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save password prompt dismiss is pushing UI up and down
4 participants
@koji-1009 @chinmaygarde @vashworth @luckysmg