Implements anti-aliased lines #164734
Implements anti-aliased lines #164734
Conversation
|
The merge conflicts will be resolved once #165622 lands. |
| @@ -329,6 +329,7 @@ ContentContext::ContentContext( | |||
| solid_fill_pipelines_.CreateDefault(*context_, options); | |||
| texture_pipelines_.CreateDefault(*context_, options); | |||
| fast_gradient_pipelines_.CreateDefault(*context_, options); | |||
| line_pipelines_.CreateDefault(*context_, options); | |||
There was a problem hiding this comment.
We could put this behind the flag context.GetFlags().antialias_lines.
| auto data_mapping = std::make_shared<fml::DataMapping>(data); | ||
| std::shared_ptr<DeviceBuffer> buffer = | ||
| context->GetResourceAllocator()->CreateBufferWithCopy(*data_mapping); |
There was a problem hiding this comment.
I suspect this is doing a double copy of the texture data. I didn't change it though since it was already like this.
There was a problem hiding this comment.
we always have to copy host visible data into a staging buffer, unless we allocate the buffer first and write it in there. Its OK for now
There was a problem hiding this comment.
I had a linter in this so I took the opportunity to switch it to a single copy by using NonOwningMapping. We were copying to the mapping then copying to the device buffer, now we are just copying to the device buffer.
I haven't created solid plans yet since it's moot if we can't get something that looks good. For solid colors the order of operations of the path don't matter so my thought it so split out lines from the rest of the path and use the new line shaders for the straight lines. Can be transformed to: |
|
Could work! Or we could detect straight line only bezier paths.. or something like that We should definitely only try to do AA lines for solid colors. No worry about gradients or things like that. |
|
@jonahwilliams this is landing with radius 0.5 which looked good in the playgrounds. On device the radius 1 looks better. The lines are brighter, but they aren't any wider because of MSAA. It also looks like I have blending wrong with the new line. regularantialias w/ 1.0 radius |
|
Here's radius 2.0. This looks good but in this case sometimes the lines are 3 pixels tall instead of 2 in the old case. |
issue: #138682
design doc: https://docs.google.com/document/d/19I6ToHCMlSgSava-niFWzMLGJEAd-rYiBQEGOMu8IJg/edit?tab=t.0
This puts an experimental line drawing approach behind the following flags:
FLTAntialiasLinesboolean, default NOio.flutter.embedding.android.ImpellerAntialiasLinesboolean, default falseRight now they just support DrawLines and don't support line caps.
A test was added that works as a playground for vulkan, opengles and metal. Only the Metal version was turned into a golden test though here.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.