Refactors to widget_preview #164783
Refactors to widget_preview #164783
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| ); | ||
|
|
||
| // Adds a dependency on flutter_lints, which is referenced by the | ||
| // And a dependency on flutter_lints, which is referenced by the |
There was a problem hiding this comment.
Ubernit: 'Also adds a dependency on flutter_lints...'
|
Thanks Sigurd! |
Fixes the order of operations in initialBuild.
ensureReadyForPlatformSpecificToolingrelies onpackage_config.jsonexisting (though currently it will silently ignore it missing).This showed up while working on #160443 .
Also reduce the number of
pubinvocations needed.pub addcan add multiple dependencies at once, and will do a full resolution, so the finalpub getis not needed.Also use a relative path for pub add.