Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add carousel view theme #164769

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat: Add carousel view theme #164769

wants to merge 3 commits into from
+442 −9

Conversation

rkishan516
Copy link
Contributor

Feat: Add carousel view theme
fixes: #159679

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 7, 2025
@rkishan516 rkishan516 force-pushed the carousel-view-theme branch from 6c97e25 to 6f294d0 Compare March 7, 2025 07:04
navaronbracke
navaronbracke reviewed Mar 7, 2025
View reviewed changes
packages/flutter/lib/src/material/carousel.dart Outdated
final double effectiveElevation = widget.elevation ?? 0.0;
widget.backgroundColor ??
carouselTheme.backgroundColor ??
Theme.of(context).colorScheme.surface;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Theme.of(context).colorScheme.surface;
ColorScheme.of(context).surface;

packages/flutter/lib/src/material/carousel.dart
const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(28.0)));
final WidgetStateProperty<Color?> effectiveOverlayColor =
widget.overlayColor ??
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is duplicated? You probably mean to use the CarouselTheme's overlay color.

@rkishan516 rkishan516 force-pushed the carousel-view-theme branch 2 times, most recently from 134c5f6 to 7fdbad4 Compare March 7, 2025 23:17
@rkishan516 rkishan516 requested a review from navaronbracke March 7, 2025 23:20
@rkishan516 rkishan516 force-pushed the carousel-view-theme branch from ce0963f to c30bd61 Compare March 11, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navaronbracke navaronbracke Awaiting requested review from navaronbracke

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow customizing CarouselView in ThemeData
2 participants
@rkishan516 @navaronbracke