Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add hintMaxLines in InputDecorationTheme #164695

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feat: Add hintMaxLines in InputDecorationTheme #164695

wants to merge 2 commits into from
+40 −1

Conversation

rkishan516
Copy link
Contributor

@rkishan516 rkishan516 commented Mar 6, 2025 •
edited
Loading

Feat: Add hintMaxLines in InputDecorationTheme
fixes: #164656

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 6, 2025
@rkishan516 rkishan516 marked this pull request as ready for review March 6, 2025 10:53
@vasilich6107
Copy link
Contributor

Hi @Piinks
This is a tiny PR which helps to consistently handle input decorator theming.
Could you help with merging it or point to the person that could help with

@dkwingsmt dkwingsmt requested a review from justinmc March 12, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc Awaiting requested review from justinmc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InputDecorationTheme is missing hintMaxLines
2 participants
@rkishan516 @vasilich6107