Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mac_mokey microbenchmarks with issue to the bringup: true in ci config for easier discovery #164694

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Update Mac_mokey microbenchmarks with issue to the bringup: true in ci config for easier discovery #164694

merged 1 commit into from
Mar 12, 2025
+1 −1

Conversation

harri35
Copy link
Contributor

@harri35 harri35 commented Mar 6, 2025

Update the comment in .ci.yaml with the issue link for easier discovery.
Related issue: #156506
Related discussion: #162000

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@harri35 harri35 self-assigned this Mar 6, 2025
@harri35 harri35 requested a review from jtmcdole March 6, 2025 09:03
This was referenced Mar 6, 2025
Closed
Merged
@harri35
Copy link
Contributor Author

harri35 commented Mar 12, 2025

@jtmcdole If you have a minute, please "review" this. Then it will be easier for others in the future to connect things :)

@jtmcdole jtmcdole changed the title Link the Mac_ios microbenchmarks_ios issue to the bringup: true in ci config for easier discovery Update Mac_mokey microbenchmarks with issue to the bringup: true in ci config for easier discovery Mar 12, 2025
@jtmcdole jtmcdole added this pull request to the merge queue Mar 12, 2025
Merged via the queue into flutter:master with commit eef31a1 Mar 12, 2025
151 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
b93db39 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
d2961cc 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
af57214 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
3ae53b6 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
f8b6238 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
67742bd 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
7aa3000 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
e2055b0 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
f1b86e1 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
354c27c 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
fb12b57 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
8acfffb 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
7fc72e6 
… true in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
da180f8 
… true in ci config for easier discovery (flutter/flutter#164694)
This was referenced Mar 13, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
6845a11 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
bc66ada 
… true in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
f0a5e9c 
… true in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
b8632e1 
… true in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
dd59862 
… true in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
c9f1e94 
… true in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
0724d54 
… true in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
443c794 
… true in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
c5f276d 
… true in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025
@engine-flutter-autoroll
eef31a1c2 Update Mac_mokey microbenchmarks with issue to the bringup:…
a2ae8f0 
… true in ci config for easier discovery (flutter/flutter#164694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

@harri35 harri35

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harri35 @jtmcdole