Fix: DelegateTransition for cupertino sheet route #164675
Conversation
There was a problem hiding this comment.
I'll defer to @MitchellGoodwin on this. I think this probably needs a new test that covers this case at least though.
| final Rect clipRect = tester.getRect(clipRRectFinder); | ||
| expect(clipRect.center, equals(const Offset(400, 300))); | ||
| expect(clipRRectFinder, findsNothing); |
There was a problem hiding this comment.
Why did this change exactly?
Ideally it would be nice if you could write a test that reproduces the error in #163954 and expect that it doesn't happen anymore.
There was a problem hiding this comment.
Since after popping this clipper doesn't exist anymore, that's why added this.
But yeah, it will make more sense to add another test which replicates error in #163954
| if (child != null && secondaryAnimation.isDismissed) { | ||
| return child; | ||
| } |
There was a problem hiding this comment.
Could you explain why this fixes the bug for my own understanding?
There was a problem hiding this comment.
After coming back from sheet, if it shows SlideTransition which internally uses RenderFractionalTranslation which doesn't have size because its just a proxy box. So, throws the error as seen in #163954.
Also, it makes sense to just return page, when we have fully popped of from sheet.
2b7c256 to
35e0e3c
Compare
Fix: DelegateTransition for cupertino sheet route
fixes: #163954
Pre-launch Checklist
///).