Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

computeDryLayout access size bad #164663

Merged
merged 10 commits into from
Mar 12, 2025
Merged

computeDryLayout access size bad #164663

merged 10 commits into from
Mar 12, 2025

Conversation

LongCatIsLooong
Copy link
Contributor

Asserts if RenderBox.size is accessed in computeDryLayout

Also changes x is RenderObject to x != null when x's static type is RenderObject?.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Mar 5, 2025
@github-actions github-actions bot added the f: material design flutter/packages/flutter/material repository. label Mar 6, 2025
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review March 6, 2025 23:48
goderbauer
goderbauer approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the x is RenderObject cleanup!

@goderbauer
Copy link
Member

Looks like there was a problem running "Google testing". Does this break anything there?

@LongCatIsLooong
Copy link
Contributor Author

The failure seems to be infra related. On frob the PR status is deleted. Pushed a new commit.

chunhtai
chunhtai approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2025
@goderbauer
Copy link
Member

FYI: Looks like something got stuck here?

@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Mar 11, 2025

autosubmit label was removed for flutter/flutter/164663, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2025
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #164663 at sha a590c25

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 11, 2025
@LongCatIsLooong
Copy link
Contributor Author

CL/735809763 has passed TGP.

@LongCatIsLooong LongCatIsLooong added autosubmit Merge PR when tree becomes green via auto submit App and removed will affect goldens Changes to golden files labels Mar 12, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 12, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
5126c25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
f4c6c50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
db58f57
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
ce725e5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
8961973
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
2d9fa4a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
1e67cc8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
5f6cbd9
This was referenced Mar 13, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
8717851
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
a7b8ad1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
63233ab
@Piinks Piinks mentioned this pull request Mar 14, 2025
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
90cd92a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
d43e36b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
6ba5e01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
a7b3116
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
647b847
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
64c1990
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025
@engine-flutter-autoroll
963f23e30 computeDryLayout access size bad (flutter/flutter#164663)
ff9aae5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TahaTesser TahaTesser TahaTesser left review comments

@goderbauer goderbauer goderbauer approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LongCatIsLooong @goderbauer @chunhtai @TahaTesser