Fix SwiftPM scheme migration to handle when there are no BuildActionEntries #164660

vashworth · 2025-03-05T22:30:39Z

An Xcode scheme may or may not have BuildActionEntries. When migrating to SwiftPM, if Flutter cannot find BuildActionEntries in the xcscheme, append the PreAction to the end of the BuildAction.

Fixes #163086.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…ntries

...er_tools/test/general.shard/migrations/swift_package_manager_integration_migration_test.dart

loic-sharma

Looks good - apologies for the late review!

…ildActionEntries (flutter/flutter#164660)

Fix SwiftPM scheme migration to handle when there are no BuildActionE…

0dbac2e

…ntries

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 5, 2025

vashworth marked this pull request as ready for review March 6, 2025 15:43

vashworth requested a review from loic-sharma March 6, 2025 15:43

loic-sharma reviewed Mar 10, 2025

View reviewed changes

...er_tools/test/general.shard/migrations/swift_package_manager_integration_migration_test.dart Outdated Show resolved Hide resolved

loic-sharma approved these changes Mar 10, 2025

View reviewed changes

vashworth and others added 3 commits March 11, 2025 11:18

fix typo

93c9105

Merge branch 'master' into fix_swiftpm_build_action_scheme_migration

5171974

Merge branch 'master' into fix_swiftpm_build_action_scheme_migration

557036b

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025

auto-submit bot added this pull request to the merge queue Mar 12, 2025

Merged via the queue into flutter:master with commit 03f1208 Mar 12, 2025
134 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to c6c518653c39 (56 revisions) flutter/packages#8865

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

c9de4d0

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to ea4cdcf39e93 (57 revisions) flutter/packages#8866

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

c2b0afa

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 884de6185518 (58 revisions) flutter/packages#8867

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

e5560e2

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 0a937ba4dafc (59 revisions) flutter/packages#8868

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

60a1d4b

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 627f1d200bac (60 revisions) flutter/packages#8869

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

16c330b

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 0aa0ad160ed2 (61 revisions) flutter/packages#8870

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

4527736

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

8f67ab8

…ildActionEntries (flutter/flutter#164660)

This was referenced Mar 13, 2025

Roll Flutter from b16430b2fd57 to c38f0b7aaee3 (63 revisions) flutter/packages#8871

Closed

Roll Flutter from b16430b2fd57 to 208883fe1256 (76 revisions) flutter/packages#8875

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

687ec37

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll mentioned this pull request Mar 14, 2025

Roll Flutter from b16430b2fd57 to ca287b67e1a4 (77 revisions) flutter/packages#8876

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

bd8e0f9

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll mentioned this pull request Mar 14, 2025

Roll Flutter from b16430b2fd57 to 7df335fe447e (78 revisions) flutter/packages#8877

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

6cace3e

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

f3dba67

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

ad048fb

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

03cf2b2

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

f6923fe

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

25241ba

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

cb61fed

…ildActionEntries (flutter/flutter#164660)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025

03f120872 Fix SwiftPM scheme migration to handle when there are no Bu…

a30af1b

…ildActionEntries (flutter/flutter#164660)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix SwiftPM scheme migration to handle when there are no BuildActionEntries #164660

Fix SwiftPM scheme migration to handle when there are no BuildActionEntries #164660

vashworth commented Mar 5, 2025

loic-sharma left a comment

Fix SwiftPM scheme migration to handle when there are no BuildActionEntries #164660

Fix SwiftPM scheme migration to handle when there are no BuildActionEntries #164660

Conversation

vashworth commented Mar 5, 2025

Pre-launch Checklist

loic-sharma left a comment

Choose a reason for hiding this comment