Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Adds oval shortcut to DisplayListMatrixClipState::clip{RRect,RSuperellipse} #164519

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Mar 3, 2025

Fixes #163717

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label Mar 3, 2025
@chinmaygarde
Copy link
Member

cc @jonahwilliams

@jonahwilliams jonahwilliams self-requested a review March 10, 2025 18:26
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not sure how to test this. Are there tests for the existing shortcuts?

@chinmaygarde
Copy link
Member

@dkwingsmt You'd need to mark the Google Testing step as an "Infra failure.". The other was a flake and I've re-run it. But if there is nothing further to do on the testing front, I think we can land this.

@dkwingsmt
Copy link
Contributor Author

Will do! Yeah I looked a bit and didn't see specific tests there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Engine] Investigate why DisplayListMatrixClipState::clipRRect doesn't have an Oval shortcut
3 participants