[CP][iOS] increase max concurrent background tasks to 64. #164506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial workaround for flutter#161142 . Since this was an arbitrary number anyway we can increase it a bit.
jtmcdole
approved these changes
Mar 3, 2025
camsim99
approved these changes
Mar 6, 2025
reidbaker
requested changes
Mar 10, 2025
| @@ -57,7 +57,7 @@ class Context { | |||
| /// This number was arbitrarily chosen. The idea is that this is a somewhat | |||
| /// rare situation where tasks happen to get executed in that tiny amount of | |||
| /// time while an app is being backgrounded but still executing. | |||
| static constexpr int32_t kMaxTasksAwaitingGPU = 10; | |||
| static constexpr int32_t kMaxTasksAwaitingGPU = 64; | |||
There was a problem hiding this comment.
Is there a test as part of another pr for this? Or is this fix something that is not testable?
|
I will also take @jtmcdole override that we need a test. |
It's a magic number. I don't believe there's value in writing a test for the cherry pick. I'll ask if we can add something later to only passes if this was set to 64 (e.g. creating a bunch of images) |
reidbaker
approved these changes
Mar 10, 2025
|
autosubmit label was removed for flutter/flutter/164506, because - The status or check suite Mac tool_integration_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/164506, because Pull request flutter/flutter/164506 is not in a mergeable state. |
9999151
into
flutter:flutter-3.29-candidate.0
150 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161142