-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web] fix Image fit when using ImgElementPlatformView #164400
base: master
Are you sure you want to change the base?
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GiacomoPignoni welcome! It looks like this change does not have tests. We'll need those to ensure this works as expected, and to prevent regressions in the future. Can you add tests to this change?
8fc4393
to
7f74d63
Compare
Hello @Piinks |
@GiacomoPignoni Thanks for the tests, but it looks like there are some failed checks now, can you take a look? |
@justinmc I'm sorry but I'm not really good at understating the problem
|
Hi @GiacomoPignoni have you tried rebasing with the tip of tree to resolve the issue? |
6e42c83
to
0ac96d7
Compare
0ac96d7
to
a2f3a37
Compare
Hello, I've found the issue #163288 and I've tried to fix it.
The problem was that, to make the image appear in the right way based on the given
BoxFit
, it was needed also set the rightobject-fit
on the HTML<img>
element.So I've added it to the
ImgElementPlatformView
widget and I've also added some convenience thing inweb.dart
to set theobject-fit
propertyFixes #163288
Here is the result
before

after

Pre-launch Checklist
///
).