Update Material 2 `IconButton` padding documentation #164383

TahaTesser · 2025-02-28T16:09:53Z

Fixes Icon button with padding with wrong splash and highlight position

Description

This PR updates Material 2 IconButton padding documentation where using disproportionate padding.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

QuncCccccc

LGTM! Thanks for the doc!

How come I missed to review this easy one😉!

…er/flutter#164383)

Update Material 2 IconButton padding documentation

e938598

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 28, 2025

TahaTesser marked this pull request as ready for review February 28, 2025 18:53

TahaTesser requested a review from QuncCccccc March 3, 2025 12:44

QuncCccccc approved these changes Mar 12, 2025

View reviewed changes

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025

auto-submit bot added this pull request to the merge queue Mar 12, 2025

Merged via the queue into flutter:master with commit 234b50a Mar 12, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 12, 2025

TahaTesser deleted the m2_iconButton_padding_doc branch March 12, 2025 10:19

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to eef31a1c2b73 (34 revisions) flutter/packages#8856

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

9d3a333

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to 0bdb4d68b5b3 (35 revisions) flutter/packages#8857

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

82638a4

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to a3f63a75b083 (36 revisions) flutter/packages#8858

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

61a02f4

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to 963f23e30e67 (37 revisions) flutter/packages#8859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

40e475b

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to 212f66fbe74e (38 revisions) flutter/packages#8860

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

c21984c

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to 6316b48bca8d (39 revisions) flutter/packages#8861

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

ce15ba8

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 12, 2025

Roll Flutter from b16430b2fd57 to f0992e09655a (40 revisions) flutter/packages#8862

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

ecec7e3

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to c6c518653c39 (56 revisions) flutter/packages#8865

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

f38140d

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to ea4cdcf39e93 (57 revisions) flutter/packages#8866

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

0646910

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 884de6185518 (58 revisions) flutter/packages#8867

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

a69b54c

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 0a937ba4dafc (59 revisions) flutter/packages#8868

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

b0cc180

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 627f1d200bac (60 revisions) flutter/packages#8869

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

b693523

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 13, 2025

Roll Flutter from b16430b2fd57 to 0aa0ad160ed2 (61 revisions) flutter/packages#8870

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

9878d96

…er/flutter#164383)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

6d29005

…er/flutter#164383)

This was referenced Mar 13, 2025

Roll Flutter from b16430b2fd57 to c38f0b7aaee3 (63 revisions) flutter/packages#8871

Closed

Roll Flutter from b16430b2fd57 to 208883fe1256 (76 revisions) flutter/packages#8875

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

05b6688

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 14, 2025

Roll Flutter from b16430b2fd57 to ca287b67e1a4 (77 revisions) flutter/packages#8876

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

8c967ca

…er/flutter#164383)

engine-flutter-autoroll mentioned this pull request Mar 14, 2025

Roll Flutter from b16430b2fd57 to 7df335fe447e (78 revisions) flutter/packages#8877

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

6305ac4

…er/flutter#164383)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

28f6236

…er/flutter#164383)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

317a1cc

…er/flutter#164383)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

22558d7

…er/flutter#164383)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

3322617

…er/flutter#164383)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

ab5c5ba

…er/flutter#164383)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

35e7d13

…er/flutter#164383)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025

234b50aa5 Update Material 2 IconButton padding documentation (flutt…

e657e1f

…er/flutter#164383)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Material 2 `IconButton` padding documentation #164383

Update Material 2 `IconButton` padding documentation #164383

TahaTesser commented Feb 28, 2025 •

edited

Loading

QuncCccccc left a comment

Update Material 2 IconButton padding documentation #164383

Update Material 2 IconButton padding documentation #164383

Conversation

TahaTesser commented Feb 28, 2025 • edited Loading

Description

Pre-launch Checklist

QuncCccccc left a comment

Choose a reason for hiding this comment

Update Material 2 `IconButton` padding documentation #164383

Update Material 2 `IconButton` padding documentation #164383

TahaTesser commented Feb 28, 2025 •

edited

Loading