animate cupertino time picker label #164292
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
- Remove variables that store the last selected hour, minute, and second, as the use of these variables doesn't allow animation - Remove NotificationListener that wraps hour, minute and second pickers as they are not needed anymore - Add AnimatedSwitcher to animate the label when the picker changes ref flutter#27515
|
I think we should have an agreement under #27515 for whether we should implement it before moving on with this PR. |
|
@MaironLucas Would you mind looking into my comment under #27515 ? If you don't have time for now I suggest closing this PR (we can always reopen it when we have agreed on the discussion.) |
TimePickerBefore.mp4
TimePicker-after.mp4
ref #27515
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.