Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Theme.brightnessOf method #163950

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Migrate to Theme.brightnessOf method #163950

wants to merge 2 commits into from
+150 −20

Conversation

rkishan516
Copy link
Contributor

Refactor: Migrate to Theme.brightnessOf method
fixes: #163837

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@rkishan516 rkishan516 marked this pull request as draft February 23, 2025 06:16
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Feb 23, 2025
@matanlurey matanlurey removed their request for review February 23, 2025 19:42
@rkishan516 rkishan516 force-pushed the brightness-of-theme-impl branch from 17eabec to 5d4988e Compare March 1, 2025 01:21
@rkishan516 rkishan516 force-pushed the brightness-of-theme-impl branch from 5d4988e to 1a4ea03 Compare March 15, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey Awaiting requested review from matanlurey matanlurey will be requested when the pull request is marked ready for review matanlurey is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal] Migrate framework Material widgets to Theme.brightnessOf(context)
1 participant
@rkishan516